Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-8912 update to model types #5800

Merged
merged 5 commits into from
Sep 10, 2024
Merged

Conversation

brendanbond
Copy link
Contributor

@brendanbond brendanbond commented Sep 9, 2024

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-8912

Description

Multivalue component data normalization now depends on @formio/core model types (formio/core#146), which handles the case of e.g. custom components or hidden components that can have array-like data models but don't opt in to multiple or register their own data model type.

Breaking Changes / Backwards Compatibility

n/a

Dependencies

How has this PR been tested?

Added automated tests, tested manually

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@TanyaGashtold TanyaGashtold merged commit a8ed692 into master Sep 10, 2024
5 checks passed
lane-formio pushed a commit that referenced this pull request Sep 10, 2024
* update normalization to utilize component model types if applicable; fix tests

* update to core dependency

* add tests

* minor update to tests

* update deps, fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants