Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-8951: Updated conditions for selectData and added logic to clear selectData #5807

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

roma-formio
Copy link
Contributor

@roma-formio roma-formio commented Sep 12, 2024

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-8951

Description

Issue: The selectData property was added to resolve issues with default values and lazy loading here. However, after switching to the HTML5 widget, it triggers the calculation of the selectData property and causes issues with the select component when the entire object is set. This occurs because the clearing logic hasn't been added, and the conditions do not fully cover cases when selectData should be used.

Solution: Update the conditions for the selectData property and add additional checks in the selectData calculation to prevent cases where the logic can be executed before the conditions are met.

How has this PR been tested?

Unit testing

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@brendanbond brendanbond merged commit e70c3bc into master Sep 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants