Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-9184: Fixed edit grid row validation for new row #5855

Merged
merged 4 commits into from
Oct 10, 2024

Conversation

roma-formio
Copy link
Contributor

@roma-formio roma-formio commented Oct 10, 2024

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9184

Description

Issue: The shouldValidateRow method currently checks for EditRowState.New, which causes the validation of a new row on any change.

Solution: Replace EditRowState.New with EditRowState.Saving to ensure that the new row is validated only after an attempt to save it.

How has this PR been tested?

Unit tests, manually

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

Copy link
Contributor

@brendanbond brendanbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roma-formio mannnnnnn I tried to fix the merge conflicts in the test file and may have clobbered things, but it looks like tests are failing

@brendanbond brendanbond merged commit bcf06c2 into master Oct 10, 2024
5 checks passed
@brendanbond brendanbond deleted the FIO-9184-fix-edit-grid-new-row-validation branch October 10, 2024 16:38
lane-formio pushed a commit that referenced this pull request Oct 15, 2024
…alidation

FIO-9184: Fixed edit grid row validation for new row
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants