Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-9196: Fixed issue with getting default value instead of requested value in Day component #5857

Merged

Conversation

roma-formio
Copy link
Contributor

@roma-formio roma-formio commented Oct 11, 2024

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9196

Description

Issue: The DataTable is calling the method getValueAsString to get the string representation of a value from the submission. The getValueAsString method internally calls the getDate method, which uses the default value of the component if the value is empty. This results in the DataTable showing the default value instead of a blank.

Solution: Add a check to see if the value is not set. If the value is not set, return an empty string without calling the internal method getDate.

How has this PR been tested?

Unit tests and manually

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@brendanbond brendanbond merged commit b9f7b8b into master Oct 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants