FIO-9144 Fix cursor jump in number component #5859
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-9144
Description
What changed?
There's a function called
restoreCaretPosition
inComponent.js
that restores the position of the input caret after a refresh. However, in this case, it was not taking the input value's delimiters into account. It might have to do with the time it takes to update the input mask. This PR changesrestoreCaretPosition
to use the length of the input value instead ofroot.currentSelection
so that delimiters are included in thesetSelection()
call.Why have you chosen this solution?
The input value was already within the scope of the function; this solution doesn't mutate
root.currentSelection
.Breaking Changes / Backwards Compatibility
n/a
Dependencies
n/a
How has this PR been tested?
Added test for number component that asserts the correct input selection start (caret/cursor) position after calling
restoreCaretPosition
on it.Checklist: