Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-9072: removed setting dirty flag to true on set submission and changed tests #5860

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

ZenMasterJacob20011
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9072

Description

What changed?

Removed the dirty flag being set to true on submission. This also required test changes because some tests set submissions and then check for visible errors using class names or message containers

Why have you chosen this solution?

This solution removes the root cause of errors unexpectedly occurring on form load by removing set submission causing components to become dirty

Breaking Changes / Backwards Compatibility

This PR goes directly against a previous test that I changed to should not show errors on ...

  • it('Should show errors on setSubmission when providing explicit data values.')

Dependencies

N/A

How has this PR been tested?

One of the automated tests I changed makes sure that set submission does not create visible errors. I also manually tested

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@travist
Copy link
Member

travist commented Oct 16, 2024

👍

@travist travist merged commit 8dbfe8d into master Oct 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants