FIO-9072: removed setting dirty flag to true on set submission and changed tests #5860
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-9072
Description
What changed?
Removed the dirty flag being set to true on submission. This also required test changes because some tests set submissions and then check for visible errors using class names or message containers
Why have you chosen this solution?
This solution removes the root cause of errors unexpectedly occurring on form load by removing set submission causing components to become dirty
Breaking Changes / Backwards Compatibility
This PR goes directly against a previous test that I changed to should not show errors on ...
Dependencies
N/A
How has this PR been tested?
One of the automated tests I changed makes sure that set submission does not create visible errors. I also manually tested
Checklist: