Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-9197: Fix Day component triggered required validation when loading form #5864

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

mikekotikov
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9197

Description

What changed?

Made a check to count before 9.3.x '00/00/0000' value as empty. Added convertion to an empty string if this value is met.

Why have you chosen this solution?

Use this section to justify your choices

Breaking Changes / Backwards Compatibility

Checked against such scenarios, haven't noticed any issues

  1. application that uses 4.x renderer works with 9.3.x server validations.

  2. application that uses 5.x renderer works with 8.x server validations.

  3. application that uses 5.x renderer works with 9.2.x server validations.

  4. application that uses 5.x renderer works with 9.3.x server validations.

Dependencies

None

How has this PR been tested?

Automated test added

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@johnformio johnformio merged commit 47de51a into master Oct 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants