FIO-9176: fix rewriting of component path in eachComponent #5867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Maria-Golomb
force-pushed
the
FIO-9176-error-validation-link-fix
branch
from
78ece1c to
8552ccf
Compare
TanyaGashtold
requested changes
Oct 18, 2024
| @@ -1777,7 +1777,7 @@ export default class Webform extends NestedDataComponent { | |||
| return; | |||
| } | |||
| const captchaComponent = []; | |||
| eachComponent(this.components, (component) => { | |||
| this.eachComponent((component) => { | |||
There was a problem hiding this comment.
this.eachComponent iterates only through direct children, but eachComponent from utils iterates all components tree. This change can break captcha.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-9176
Description
In triggerCaptcha function use webform's eachComponent. This avoids setting incorrect path for components inside editgrid components with openWhenEmpty parameter.
Dependencies
formio/core#170
How has this PR been tested?
autotests
manually
Checklist: