Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-9189: moved some methods to core #5870

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

TanyaGashtold
Copy link
Contributor

@TanyaGashtold TanyaGashtold commented Oct 17, 2024

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9189

Description

What changed?

Some methods have been moved to the core to prevent repetition of the logic.

Dependencies

formio/core#174

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@TanyaGashtold TanyaGashtold marked this pull request as draft October 17, 2024 13:12
@TanyaGashtold TanyaGashtold marked this pull request as ready for review October 17, 2024 13:12
@brendanbond brendanbond merged commit af52e2d into master Oct 18, 2024
5 checks passed
lane-formio pushed a commit that referenced this pull request Oct 22, 2024
…elect-resource

FIO-9189: moved some methods to core
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants