Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-9228: fixed an issue where error messages are duplicated in error list for nested wizard #5873

Merged

Conversation

TanyaGashtold
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9228

Description

What changed?

Errors for nested wizard were not added to the errors array of the parent form due to wrong arguments order in checkValidity . For that reason, the the from was considered to be valid and could be submitted. As a result, the server validation errors and front end validation errors where joined and duplicated in errors list. This PR pass arguments for checkValidity in right order.

How has this PR been tested?

Manually + auto tests

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@johnformio johnformio merged commit 59375c3 into master Oct 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants