Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-9176: update rewriting of components path into EditGrid with openWhenEmpty #5875

Closed

Conversation

Maria-Golomb
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9176

Description

Function eachComponent was replaced with eachComponentData with empty data in triggerCaptcha.
Those changes allow to set path to the component inside EditGrid components with openWhenEmpty parameter in the format: EditGridKey[i].componentKey. Which ensures correct access to the component via the reference in the validation error.

Dependencies

formio/core#170

How has this PR been tested?

autotests
manually

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant