Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-9173: Allow Scientific Notations #5878

Merged
merged 4 commits into from
Oct 28, 2024
Merged

FIO-9173: Allow Scientific Notations #5878

merged 4 commits into from
Oct 28, 2024

Conversation

edwinanciani
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9173

Description

What changed?

I added a new configuration to allow us to check for Scientific notation and transform it to a number

Why have you chosen this solution?

This was discussed, and I've chosen this solution not to modify our number component too much

Breaking Changes / Backwards Compatibility

Use this section to describe any potentially breaking changes this PR introduces or any effects this PR might have on backwards compatibility

Dependencies

Depends on text-mask-addons PR formio/text-mask#5

How has this PR been tested?

Unit Test

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@johnformio
Copy link
Contributor

parseFloat was correctly converting strings in scientific notation for me. You might try that and see if it works okay.

@travist
Copy link
Member

travist commented Oct 28, 2024

👍

@lane-formio lane-formio merged commit 7c5966f into master Oct 28, 2024
5 checks passed
lane-formio pushed a commit that referenced this pull request Oct 28, 2024
* FIO-9173: Allow Scientific Notations

* FIO-9173: Fixing index

* FIO-9173: Adding more tests & using parseFloat instead of Number
lane-formio pushed a commit that referenced this pull request Oct 29, 2024
* FIO-9173: Allow Scientific Notations

* FIO-9173: Fixing index

* FIO-9173: Adding more tests & using parseFloat instead of Number
edwinanciani added a commit that referenced this pull request Oct 30, 2024
FIO-9173: Allow Scientific Notations (#5878)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants