Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-9170 Added a fix for default templates to include custom components #5940

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

antonSoftensity
Copy link
Contributor

@antonSoftensity antonSoftensity commented Dec 6, 2024

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9170

Description

What changed?

Previously, if a module (i.e. premium) had their own components, there was no fallback for the template in the case of different template library usage (i.e. if 2 modules were registered and on of them is currently in use, then the components from the other were using defaultTemplate fallback, which was always just a bootstrap set of templates. I've added an ability to add extra components to the defaultTemplates when registering modules, so that for every module there is a fallback for their own components inside of the defaultTemplates

Breaking Changes / Backwards Compatibility

Use this section to describe any potentially breaking changes this PR introduces or any effects this PR might have on backwards compatibility

How has this PR been tested?

Tested locally

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@johnformio johnformio merged commit 7d4e90c into master Dec 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants