FIO-9385 Preserve non-default widget settings after evaluating field logic #5950
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-9385
Description
What changed?
Set
this.originalComponent
in theDateTime
andTextField
components. Sincethis.originalComponent
was only being set when the component was initialized and the non-default widget settings are applied after, none of those widget settings were preserved after field logic was evaluated (see here) due tothis.originalComponent
being used to updatethis.component
after evaluation.Since the non-default widget settings were not preserved after evaluating field logic,
this.settings.readOnly
was not present inCalendarWidget
when setting the value, which for some reason caused the wrong timezone to display in theDateTime
component (see Jira ticket).Why have you chosen this solution?
I wanted to fix the bug closer to the source of the issue. It seems that in the case of
DateTime
andTextField
components, no non-default widget settings were being applied tothis.originalComponent
such that any non-default widget settings would be wiped after evaluating field logic. The original bug report didn't touch onTextField
s, but I wanted to address any potential bugs there as well.Breaking Changes / Backwards Compatibility
n/a
Dependencies
n/a
How has this PR been tested?
Automated and manual testing.
Checklist: