fix: provide overrides for react-json-view with react18 version #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This method also applies to Let me know if this needs to be override as well, or I could try converting it from |
hokwanhung
force-pushed
the
fix-react18-dependencies
branch
from
4957acf to
04d8c3b
Compare
|
Revert unnecessary changes in |
|
This fix worked me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add temporary overrides for
reactversion over 18, withreact-json-viewdependency (mentioned in #65).The problem of unsuccessful
npm installis becausereact-json-viewhas been depreciated for over 3 years, and it does not supportreact18(according to Doesn't support React 18? #441).The two methods are:
Either to change the uses of
react-json-viewto other packages, namely the recommended ones of @microlink/react-json-view, @YYsuni/react18-json-view or others.Or to provide
overrides(similar effect as--legacy-peer-deps).This pull request uses the second method, and reduce the users' method of manually force
npm install.If needed, I could also create a sample version of method 1 - swapping
react-json-viewwith other packages.resolves #65