Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chain id in Metrics #300

Merged
merged 4 commits into from
Jan 29, 2024
Merged

Chain id in Metrics #300

merged 4 commits into from
Jan 29, 2024

Conversation

dkeysil
Copy link
Contributor

@dkeysil dkeysil commented Jan 18, 2024 •
edited
Loading

  • Including Chain ID to the metrics to allow bots send batches of metrics related to different blockchains
  • All the possible metrics also now listed in forta-core-go library to be reused later in the Node and other Forta parts

aomerk
aomerk reviewed Jan 18, 2024
View reviewed changes
protocol/agent.pb.go Outdated Show resolved Hide resolved
@dkeysil dkeysil requested review from canercidam and aomerk January 19, 2024 16:41
@dkeysil dkeysil marked this pull request as ready for review January 19, 2024 16:56
@dkeysil dkeysil force-pushed the kisel/forta-1404-extend-metrics branch from c918ca2 to 18281ff Compare January 22, 2024 08:30
canercidam
canercidam reviewed Jan 22, 2024
View reviewed changes
domain/metrics.go Outdated Show resolved Hide resolved
@dkeysil dkeysil merged commit af53540 into master Jan 29, 2024
1 check passed
@canercidam canercidam deleted the kisel/forta-1404-extend-metrics branch January 29, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canercidam canercidam canercidam approved these changes

@aomerk aomerk Awaiting requested review from aomerk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dkeysil @canercidam @aomerk