try to add a better localhost resolver. See issue #44 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6,23 +6,25 @@ | |||
| <content url="file://$MODULE_DIR$"> | |||
| <sourceFolder url="file://$MODULE_DIR$/src/main/java" isTestSource="false" /> | |||
There was a problem hiding this comment.
are these changes related to this feature?
There was a problem hiding this comment.
probably not, possibly new intellij version did this when importing the maven project.
otherwise it wouldn't recognize imports etc.
There was a problem hiding this comment.
ok. so please consider reverting these file changes
|
@itaifrenkel I hope I didn't forget anything, thanks. |
|
Opening new PR for submission. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A "Smarter" localhost resolver:
see issue riemann#44
Trying to avoid a lot of calls to java.net.InetAddress.getLocalHost()
which under AWS seem to trigger DNS resolving and have non-zero (~10ms) latency per event.
Usually, the hostname doesn't change so often to warrant a real query.
A real call to java.net.InetAddress.getLocalHost().getHostName()
is made only if:
AND