-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgraded UI, Fixed minor bugs, Added Instructions for Production #31
Conversation
ashirrwad
commented
Sep 7, 2022
- I have restructured the UI to ease understanding for users.
- The Tutorial now has a prompt and uses the main editor instead of code snippets.
- Added a fix for Using a missing module reports no error in the terminal #23
- Also added tweaks to pre build libraries as stated in Pre-building common libraries in the container #24
- Fixed minor faults in the README and added instructions for production.
@everythingfunctional @milancurcic please assist with review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are certainly some little things that could be improved, and we gave some suggestions in our call, but I'd be happy merging this as is and addressing anything else as separate PRs.
I will give a couple of hours for @milancurcic or @arjenmarkus to comment in case they think anything needs to be addressed as part of this PR, but then I'll merge it. |
I'll add the small tweaks like button positioning and text edits within 20 mins, things like Developer's guide can be pushed with another PR. |
Just let me know when it's ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, let's go ahead with it and we'll iterate on it in separate PRs.
👍 I'm going to go ahead and merge. Let's focus on getting this deployed now. We can iterate on UI a little bit if we have time after that. |