Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded UI, Fixed minor bugs, Added Instructions for Production #31

Merged
merged 10 commits into from
Sep 8, 2022

Conversation

ashirrwad
Copy link
Member

@ashirrwad
Copy link
Member Author

@everythingfunctional @milancurcic please assist with review.

Copy link
Member

@everythingfunctional everythingfunctional left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are certainly some little things that could be improved, and we gave some suggestions in our call, but I'd be happy merging this as is and addressing anything else as separate PRs.

@everythingfunctional
Copy link
Member

I will give a couple of hours for @milancurcic or @arjenmarkus to comment in case they think anything needs to be addressed as part of this PR, but then I'll merge it.

@ashirrwad
Copy link
Member Author

I'll add the small tweaks like button positioning and text edits within 20 mins, things like Developer's guide can be pushed with another PR.

@everythingfunctional
Copy link
Member

I'll add the small tweaks like button positioning and text edits within 20 mins, things like Developer's guide can be pushed with another PR.

Just let me know when it's ready

Copy link
Member

@milancurcic milancurcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, let's go ahead with it and we'll iterate on it in separate PRs.

@everythingfunctional
Copy link
Member

👍 I'm going to go ahead and merge. Let's focus on getting this deployed now. We can iterate on UI a little bit if we have time after that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants