Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add : API for Linking code samples from Fortran-lang.org and FortranTipBrowser (Resolves #51 and webpage #161) #55

Merged
merged 4 commits into from
Sep 25, 2022

Conversation

henilp105
Copy link
Member

@henilp105 henilp105 commented Sep 24, 2022

This PR adds an API to link code samples from Various sources. use format : https://play.fortran-lang.org/?code=program+hello%0D%0A++%21+This+is+a+comment+line%3B+it+is+ignored+by+the+compiler%0D%0A++print+%2A%2C+%27Hello%2C+World%21%27%0D%0Aend+program+hello%0D%0A

General Format : https://play.fortran-lang.org/?code=yourcode

Please NOTE: This format is not JSON, it is URL encoding.

Resolves :

Thanks and Regards,
Henil

CC @awvwgk @milancurcic @ashirrwad

Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing. Tested it a bit and it works as expected.

Copy link
Member

@milancurcic milancurcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! Do you mind adding a one-paragraph section to the README.md, called perhaps named "Loading Fortran code from your website in the playground" or similar. Basically, explaining that the playground can take a code query param and that it needs to be URL encoded (may not be obvious to everyone). And include the example URL that you have in this PR, but with https://play.fortran-lang.org. Maybe place the section either before or after Getting Started. It looks like we should separate the user docs from the developer docs.

@henilp105
Copy link
Member Author

@milancurcic Sure sir, will add a section after Getting started.

@henilp105
Copy link
Member Author

Also added Run Shortcut 'Control' Key or 'Command' key #44 .

@henilp105 henilp105 changed the title Add : API for Linking code samples from Fortran-lang.org and FortranTipBrowser (Resolves #51 and webpage #161) Add : API for Linking code samples from Fortran-lang.org and FortranTipBrowser (Resolves #51 #44 and webpage #161) Sep 24, 2022
@henilp105 henilp105 requested review from milancurcic and awvwgk and removed request for milancurcic and awvwgk September 24, 2022 14:05
@henilp105
Copy link
Member Author

@awvwgk @milancurcic Would like to request review from both.

Thanks and Regards,
Henil

@henilp105 henilp105 requested review from milancurcic and awvwgk and removed request for awvwgk and milancurcic September 24, 2022 14:07
frontend/src/App.js Outdated Show resolved Hide resolved
@awvwgk
Copy link
Member

awvwgk commented Sep 24, 2022

The code linking seems finished and ready to merge, I would suggest to split the keyboard short cut to a separate PR, since this might need further discussion and testing.

@henilp105
Copy link
Member Author

henilp105 commented Sep 24, 2022

Sure sir. @awvwgk

@henilp105 henilp105 changed the title Add : API for Linking code samples from Fortran-lang.org and FortranTipBrowser (Resolves #51 #44 and webpage #161) Add : API for Linking code samples from Fortran-lang.org and FortranTipBrowser (Resolves #51 and webpage #161) Sep 24, 2022
@awvwgk awvwgk merged commit 17e9cb9 into fortran-lang:main Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants