-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add : API for Linking code samples from Fortran-lang.org and FortranTipBrowser (Resolves #51 and webpage #161) #55
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sharing. Tested it a bit and it works as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you! Do you mind adding a one-paragraph section to the README.md, called perhaps named "Loading Fortran code from your website in the playground" or similar. Basically, explaining that the playground can take a code
query param and that it needs to be URL encoded (may not be obvious to everyone). And include the example URL that you have in this PR, but with https://play.fortran-lang.org. Maybe place the section either before or after Getting Started. It looks like we should separate the user docs from the developer docs.
@milancurcic Sure sir, will add a section after Getting started. |
Also added Run Shortcut 'Control' Key or 'Command' key #44 . |
@awvwgk @milancurcic Would like to request review from both. Thanks and Regards, |
The code linking seems finished and ready to merge, I would suggest to split the keyboard short cut to a separate PR, since this might need further discussion and testing. |
Sure sir. @awvwgk |
This PR adds an API to link code samples from Various sources. use format :
https://play.fortran-lang.org/?code=program+hello%0D%0A++%21+This+is+a+comment+line%3B+it+is+ignored+by+the+compiler%0D%0A++print+%2A%2C+%27Hello%2C+World%21%27%0D%0Aend+program+hello%0D%0A
General Format :
https://play.fortran-lang.org/?code=yourcode
Please NOTE: This format is not JSON, it is URL encoding.
Resolves :
Thanks and Regards,
Henil
CC @awvwgk @milancurcic @ashirrwad