preview for html and csv added #175
Conversation
|
@ashitaprasad please review the changes |
|
@BrawlerXull Add appropriate test cases for the changes that you have made in the |
Working on it :) |
I've added tests for the code @animator is it ok? |
lib/widgets/previewer.dart
Outdated
| } | ||
|
|
||
| void processCsv(String body) { | ||
| print("hello"); |
lib/widgets/previewer.dart
Outdated
| @override | ||
| void initState() { | ||
| super.initState(); | ||
| csvData = []; |
There was a problem hiding this comment.
Why is csvData state being maintained in Previewer Widget.
Everything related to csv shall happen in a separate widget and the purpose of this widget is to call the right widget based on mimetype.
There was a problem hiding this comment.
Should i create a new widget for CsvPreviewer and move the logic there?
There was a problem hiding this comment.
I am really sorry for the silly mistakes I'll take care of writting clean code from now onwards
There was a problem hiding this comment.
yes it should be a new widget.
Also, CSV & HTML previewers should be in separate PRs.
Not the same PR.
|
For Expected Response:
This PR: |
|
Closing this PR as CSV was merged. You can raise a separate PR for html. |
Added preview for CSV and HTML format
Fixes #155 #156