Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: params not syncing with url #214

Closed

Conversation

mohnishdeshpande
Copy link

@mohnishdeshpande mohnishdeshpande commented Feb 27, 2024

PR Description

The PR solve the issue #166 of url parameters not syncing with request pane on pasting.

Related Issue

Checklist

  • I have gone through the contributing guide
  • I have run the tests (flutter test) and all tests are passing

Added/updated tests?

  • Yes
  • No, and this is why: There isn't any new feature introduced, just tweaking existing code.
  • I need help with writing tests

Note

The kNameValueEmptyModel has been removed, as it was causing issue with dynamic changes.
The change doesn't affect user experience in any way (the Add Param button being right next to it).
If that's acceptable, we can do the same for the headers pane as well for uniform UI.

@animator
Copy link
Member

kNameValueEmptyModel has been removed, which leads to poor user experience as now the params & headers tabs look empty. It should not be removed.

@ashitaprasad
Copy link
Member

Refer #166 (comment)

@animator animator closed this Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sync url and params tab
3 participants