Add feature to support url params having the same key and different values #276
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
NEED HELP
In order to support duplicate search params, the type of paramsMap in
RequestModel
was changed fromMap<String, String>
toMap<String, dynamic>
which matches with the queryParameters which is accepted by the Uri constructor.Going through the documentation for Uri class I have found that there are two properties, queryParameters and queryParametersAll of which former supports duplicate query parameters by returning
Map<String, List<String>>
object. Similar behaviour is also observed in NodeJS [URLSearchParams] where we haveurlSearchParams.get
andurlSearchParams.getAll
.Therefore, all the occurrences ofUri.queryParameters
were changed toUri.queryParametersAll
.The response sent also have query parameters as expected.
This however, breaks all the codegen tests as the earlier expectation was to override query params. Therefore, I have updated the requestModelGet3 to accept query params.
I have fixed the codegen for curl, but will need help to change codegen for other languages/frameworks also.
Related Issues
Checklist
flutter test
) and all tests are passingAdded/updated tests?
We encourage you to add relevant test cases.