-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: deploy Sphinx Documentation automatically to gh-pages using GitHub Actions #259
Conversation
Reviewer's Guide by SourceryThis PR automates the deployment of Sphinx documentation to GitHub Pages using a GitHub Actions workflow. The workflow is triggered by pushes to the main branch and builds the documentation using Sequence diagram for automated Sphinx documentation deploymentsequenceDiagram
participant D as Developer
participant GH as GitHub Repository
participant GA as GitHub Actions
participant GP as GitHub Pages
D->>GH: Push changes to main branch
GH->>GA: Trigger workflow
activate GA
GA->>GA: Check out repository
GA->>GA: Set up Python
GA->>GA: Install system packages
GA->>GA: Install Python dependencies
GA->>GA: Build Sphinx documentation
GA->>GP: Deploy to gh-pages branch
deactivate GA
Note over GP: Documentation live at<br/>etalk.eventyay.com
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @r3yc0n1c - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding pip dependency caching to speed up workflow runs. You can use actions/cache with pip's cache directory to avoid reinstalling packages on every run.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@r3yc0n1c Thanks for the PR. Please make a PR against the development branch. At this point of time it also makes more sense to trigger the deployment of the pages when merging into the dev branch.
done! |
Not sure what this PR is for as you already have a PR for the dev branch. Dev branches get merged to main or master after thourough testing. Closing this PR therefore. |
This PR closes/references issue #256. It does so by automating the deployment of Sphinx documentation to the
gh-pages
branch using GitHub Actions. With this workflow, every update to the documentation triggers a deployment, ensuring that the latest changes are always reflected on GitHub Pages.How has this been tested?
gh-pages
branch.Checklist
etalk.eventyay.com
Summary by Sourcery
Set up a GitHub Actions workflow to automatically deploy the Sphinx documentation to GitHub Pages on every push to the main branch.
CI:
Deployment: