Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename mail and change order #35

Closed
wants to merge 106 commits into from

Conversation

Kaushik-Iyer
Copy link
Contributor

@Kaushik-Iyer Kaushik-Iyer commented Feb 13, 2024

This PR closes/references issue #11

How has this been tested?

Results on running the server locally are:

image

Checklist

  • I have added tests to cover my changes.
  • I have updated the documentation.
  • My change is listed in the doc/changelog.rst.

Currently translated at 12.3% (188 of 1525 strings)
Co-authored-by: Matevž Špacapan <[email protected]>
Currently translated at 49.5% (755 of 1525 strings)


Translate-URL: http://translate.pretalx.com/projects/pretalx/pretalx/nl/
Translation: pretalx/pretalx

Co-authored-by: Remco Poortinga - van Wijnen <[email protected]>
Signed-off-by: Tobias Kunze <[email protected]>
marcoag and others added 6 commits February 13, 2024 23:13
Signed-off-by: Marco A. Gutierrez <[email protected]>
Signed-off-by: Marco A. Gutierrez <[email protected]>
Signed-off-by: Marco A. Gutierrez <[email protected]>
Signed-off-by: Marco A. Gutierrez <[email protected]>
Signed-off-by: Marco A. Gutierrez <[email protected]>
@mariobehling
Copy link
Member

Please deploy the system locally with the changes and add a screenshot into the PR description. Thanks

For better clarity, instead of using the acronym "CfP" we can
instead use "Call for Speakers" directly.

fixes: fossasia#9
@Kaushik-Iyer
Copy link
Contributor Author

@mariobehling I have deployed and added a screenshot above. Please have a look, thank you

Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Add button link to view or edit speaker profile fossasia#17
---------

Co-authored-by: Marco A. Gutierrez <[email protected]>
src/pretalx/locale/ca/LC_MESSAGES/django.po Outdated Show resolved Hide resolved
src/pretalx/locale/ca/LC_MESSAGES/django.po Outdated Show resolved Hide resolved
src/pretalx/locale/ca/LC_MESSAGES/django.po Outdated Show resolved Hide resolved
src/pretalx/locale/es_MX/LC_MESSAGES/django.po Outdated Show resolved Hide resolved
src/pretalx/locale/es_MX/LC_MESSAGES/django.po Outdated Show resolved Hide resolved
src/pretalx/locale/el/LC_MESSAGES/django.po Outdated Show resolved Hide resolved
src/pretalx/locale/nl/LC_MESSAGES/django.po Outdated Show resolved Hide resolved
src/pretalx/locale/nl/LC_MESSAGES/django.po Outdated Show resolved Hide resolved
src/pretalx/locale/pt_PT/LC_MESSAGES/django.po Outdated Show resolved Hide resolved
src/pretalx/locale/pt_PT/LC_MESSAGES/django.po Outdated Show resolved Hide resolved
@Kaushik-Iyer
Copy link
Contributor Author

@mariobehling @marcoag I have committed all the suggestions. But there are merge conflicts. I think the code lines mentioned in the files have been updated. You might want to have a look at one of the conflict files. Should I solve the merge conflicts also?

@norbusan
Copy link
Member

Yes, please merge the main branch into your branch, that is the normal procedure. Thanks

@Kaushik-Iyer
Copy link
Contributor Author

@norbusan I've tried to merge changes but this PR now looks really ugly. I'm assuming I need to create a new PR for the development branch instead of the main branch, or did I do something wrong?

@norbusan
Copy link
Member

Yes please, since and main and development are more or less the same, I suggest re-opening a new PR against development from the same branch. If you do this, please close this PR.

@Kaushik-Iyer
Copy link
Contributor Author

Re-opened new PR against development branch. Closing this PR now

@marcoag marcoag mentioned this pull request Feb 22, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.