Feat: Add site_name to Template Context from pretalx.cfg (Fixes #8) #37
Conversation
…cfg file This commit adds a new setting to the pretalx.cfg file to set the site/system name. This setting is used in the site header and in the page title. This feat also sets the deault site name to "Eventyay" in the CONFIG constant under config.py and sets the sample in the pretalx.example.cfg file. This change updates the tempalte pretalx/orga/templates/orga/base.html to use the new setting to set the site name in the site header and page title.
…of other views and templates
There was a problem hiding this comment.
Pleas have a look at the new changes. i was not able to make some graphic design changes due to my incompetence in design tooling, please assign the work to Designer of needed. The icon update etc was anyway out of the scope of this PR, but i have manged to add main icons and logos.
abhishekmishragithub
changed the title
I have made the changes in the new commits, please re-review and merge if looks good :) |
abhishekmishragithub
force-pushed
the
fix/#8-update-system-config-settings
branch
from
8239f1d to
4dbc369
Compare
There was a problem hiding this comment.
Please change this to 16x16 as well.
There was a problem hiding this comment.
Expected size: 550px | H: 302px
If possible make background transparent and invert blue and white.
There was a problem hiding this comment.
which logo does this file substitute? Should this be rather an .svg in src/pretalx/static/common/img/logo_white.svg?
There was a problem hiding this comment.
The new svg file here shows up as completely transparent without the eventyay text.
There was a problem hiding this comment.
This is quite big for such a small file. Please reduce the file size.
assets/logo_inverted.png
Outdated
There was a problem hiding this comment.
While the size of the image is correct now, the logo is not filling the image. There is too much space around.
assets/logo.svg
Outdated
assets/logo.png
Outdated
There was a problem hiding this comment.
Good even though you could increase the logo size (not the image size) a bit to match the previous logo.
assets/icon.svg
Outdated
There was a problem hiding this comment.
Yes, this is good as it matches the size here.
|
Rebased and fixed in #69 already merged. |
Fixes #8
This PR introduces the addition of the
site_namevariable to the context of all templates. Thesite_nameis retrieved from thepretalx.cfgconfiguration file and is now available for use in all templates, improving the flexibility and customization of the templates.Primary changes include:
site_namefrompretalx.cfgin the context.site_namecontext variable.These changes allow for a more dynamic and customizable user experience, as the site name can now be adjusted via the
pretalx.cfgconfiguration file and will be reflected across all templates.To read more about configuration read, pretalx config doc.