-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Russian and Ukrainian as active languages #45
Conversation
Do CI tests on the development branch
Okay, I will do that and revert back soon. |
src/pretalx/settings.py
Outdated
"public_code": "zh", | ||
}, | ||
"ru": { | ||
"name": _("Russian"), | ||
"natural_name": "Russian", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is not the natural name, it should be русский язык and similar for Ukraine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made the necessary changes as requested. Please check and revert back.
Also, in surprised that they're are commits of me in the branch, but I guess GitHub can figure that out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please make a pull request based on the current development branch that does NOT contain all the unrelated changes?
90% of the changes in this PR are unrelated, and I am loss reading all this
Your talking about this issue here, right? I'm a bit confused too. After making the changes you requested, I proceeded working on the third issue #19. I committed from VSCode as I usually did for the other issues. But, after creating a PR, I don't know why it's showing here. Please advise. |
There are so many issues, here, I really ask you to start over again and be a bit more careful:
I suggest:
Thanks |
Hello, Norbusan. Most of the tests that failed were due to "tinymce" library not being found. This happened because, the newly added library which exists in my local machine specifically in the project folder does not exist in the fork I created on github. I need to add this library to my fork. How do yo think I should approach this because the PR #49 requires much more work than the other PRs I have created. I'm new to this, so please guide and advise. |
Hello, Norbusan. After countless hours of figuring out using your advice, by cherry-picking commits and then pushing them to their relevant branches, the past commits keep appearing on my new branches, preventing me from creating new PRs. Please revert asap as this is hindering me from moving forward. |
This PR closes/references issue #14.
How has this been tested?
I have fixed the issue as requested by adding the two languages, "Russian" and "Ukranian" to the Active language list.Please take a look at the screenshot of the newly added languages.
To ensure if the languages can be translated, please have a look at the screenshot where I have selected "Russian" as underlined.
Now to confirm, when I visit the link http://127.0.0.1:8000/orga/event/, it takes me to a page as shown in the screenshot below, which successfully translated the language to Russian.
Now, let us test for the language "Ukranian" by similarly following the above steps.
Selecting "Ukranian" as shown in the screenshot below
Similarly, when I visit http://127.0.0.1:8000/orga/event/, I get the page in Ukranian as shown in the screenshot below.
Checklist