Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align Settings Tab with Search Bar Fixes-#914 #923

Closed
wants to merge 1 commit into from
Closed

Align Settings Tab with Search Bar Fixes-#914 #923

wants to merge 1 commit into from

Conversation

championpaddler
Copy link
Member

@championpaddler championpaddler commented Nov 1, 2018 •
edited
Loading

Changes proposed in this pull request

  • Aligning Settings Tab

Screenshots (if appropriate)

screenshot from 2018-11-01 21-38-46

Link : https://pr-923-fossasia-LoklakSearch.surge.sh

**Closes #914 **

@championpaddler
Copy link
Member Author

@praveenojha33 @simsausaurabh Please review.

@codecov
Copy link

codecov bot commented Nov 1, 2018 •
edited
Loading

Codecov Report

Merging #923 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development     #923   +/-   ##
============================================
  Coverage        50.61%   50.61%           
============================================
  Files              109      109           
  Lines             2677     2677           
  Branches           302      302           
============================================
  Hits              1355     1355           
  Misses            1290     1290           
  Partials            32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f26724...24298fc. Read the comment docs.

@praveenojha33
Copy link
Member

Please mention the surge link for your changes. So that reviewers can review your PR easily.

@championpaddler
Copy link
Member Author

Please mention the surge link for your changes. So that reviewers can review your PR easily.

Here it is . https://pr-923-fossasia-LoklakSearch.surge.sh . 😄

@championpaddler
Copy link
Member Author

@praveenojha33 Please review.

praveenojha33
praveenojha33 reviewed Nov 1, 2018
View reviewed changes
Copy link
Member

@praveenojha33 praveenojha33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not working for all screens. Please fix it for all screen sizes.
image

@praveenojha33
Copy link
Member

Also there are some texts which are overlapping in sidebar. For which I have raised an issue here #925 Can you please look into it.
Thank You.

@championpaddler
Copy link
Member Author

@prateekchaplot Can you please retry opening in private mode because it is working perfectly in my pc??

@championpaddler
Copy link
Member Author

@praveenojha33 Demo https://vimeo.com/user91264543/review/298425736/b6d12d4aa4

@praveenojha33
Copy link
Member

@praveenojha33 Please see in developer option for larger screens.
@simsausaurabh Please review it.

@championpaddler
Copy link
Member Author

@praveenojha33 ok i will test for larger screens.

@championpaddler
Copy link
Member Author

@simsausaurabh Please review

@championpaddler
Copy link
Member Author

@simsausaurabh Please review.

@championpaddler
Copy link
Member Author

@praveenojha33 Now it will work on large screens.

simsausaurabh
simsausaurabh requested changes Nov 6, 2018
View reviewed changes
Copy link
Member

@simsausaurabh simsausaurabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sk9331657 There are still some bugs, please see:

screenshot from 2018-11-06 17-49-45

@championpaddler
Copy link
Member Author

@simsausaurabh @praveenojha33 Now please check it.

simsausaurabh
simsausaurabh requested changes Nov 15, 2018
View reviewed changes
Copy link
Member

@simsausaurabh simsausaurabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still some issues, please see:

screenshot from 2018-11-15 14-35-50

screenshot from 2018-11-15 14-36-15

simsausaurabh
simsausaurabh reviewed Dec 10, 2018
View reviewed changes
Copy link
Member

@simsausaurabh simsausaurabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sk9331657 What is the update on this PR?

@simsausaurabh
Copy link
Member

Please follow up, closing due to inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praveenojha33 praveenojha33 praveenojha33 left review comments

@simsausaurabh simsausaurabh simsausaurabh requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@championpaddler @praveenojha33 @simsausaurabh