Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed issue #925 #971

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

Aaryan-kapur
Copy link

@Aaryan-kapur Aaryan-kapur commented Dec 18, 2019

fixed issue #925
fixed the overflowing during searches
Screenshot (19)

** http://pr-971-fossasia-loklaksearch.surge.sh

Closes #925

please suggest changes!

Thank You,
Aaryan Kapur

@praveenojha33
@kpulkit29
@rajvaibhavdubey

@codecov
Copy link

codecov bot commented Dec 21, 2019

Codecov Report

Merging #971 into development will increase coverage by 3.29%.
The diff coverage is 62.85%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #971      +/-   ##
===============================================
+ Coverage        61.60%   64.90%   +3.29%     
===============================================
  Files              109      109              
  Lines             2701     2704       +3     
  Branches           302      303       +1     
===============================================
+ Hits              1664     1755      +91     
+ Misses             952      866      -86     
+ Partials            85       83       -2     
Impacted Files Coverage Δ
...app/contact/contact-form/contact-form.component.ts 61.53% <33.33%> (-2.47%) ⬇️
src/app/feed/info-box/info-box.component.ts 78.72% <64.00%> (+0.30%) ⬆️
.../app/feed/user-info-box/user-info-box.component.ts 100.00% <100.00%> (ø)
src/app/shared/url-config.ts 100.00% <0.00%> (ø)
src/app/actions/query.ts 100.00% <0.00%> (+20.68%) ⬆️
src/app/reducers/query.ts 90.00% <0.00%> (+23.33%) ⬆️
...ckground/media-wall-custom-background.component.ts 100.00% <0.00%> (+27.27%) ⬆️
...ustom-header/media-wall-custom-header.component.ts 100.00% <0.00%> (+30.76%) ⬆️
src/app/reducers/news-status.ts 100.00% <0.00%> (+33.33%) ⬆️
...ll-custom-card/media-wall-custom-card.component.ts 100.00% <0.00%> (+33.33%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50d06b0...7f34cca. Read the comment docs.

@championpaddler
Copy link
Member

@Aaryan-kapur Where is your deployment link

@Aaryan-kapur
Copy link
Author

@Aaryan-kapur
Copy link
Author

@sk9331657 hey please checkout the link!!
http://pr-971-fossasia-loklaksearch.surge.sh/

@Aaryan-kapur
Copy link
Author

@sk9331657 please check

@Dishebh
Copy link
Member

Dishebh commented Jan 28, 2020

@Aaryan-kapur pls squash your commits. Also, see why codacy check is failing. Thanks.

@Aaryan-kapur Aaryan-kapur force-pushed the aaryan-development branch 3 times, most recently from b281d77 to 7f34cca Compare March 31, 2020 08:08
@Aaryan-kapur
Copy link
Author

any updates @Dishebh ?

@Aaryan-kapur
Copy link
Author

Any updates @Dishebh

@Dishebh
Copy link
Member

Dishebh commented Oct 22, 2021

LGTM

@Aaryan-kapur
Copy link
Author

@sk9331657 is this still relevant and mergable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text overlaps in sidebar for some searches.
3 participants