fix: Disable role invite processing in fastboot mode

[iamareebjamal]

Fixes #3347

[codecov]

Codecov Report

Merging #4038 into development will decrease coverage by 0.00%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           development    #4038      +/-   ##
===============================================
- Coverage        21.90%   21.90%   -0.01%     
===============================================
  Files              460      460              
  Lines             4733     4735       +2     
===============================================
  Hits              1037     1037              
- Misses            3696     3698       +2     

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5679da2...bb39871. Read the comment docs.

[kushthedude]

This is more of a workaround, to ignore the fastboot crashes in the production.

[iamareebjamal]

OK, I'll be waiting for your fix 👍

[kushthedude]

I am not saying I have fixed or this is wrong. We can atleast let the issue open to see what is causing the crashes and fix it in near future.

…

On Mon, 10 Feb, 2020, 11:30 Areeb Jamal, ***@***.***> wrote: OK,I'll be waiting for your fix — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#4038?email_source=notifications&email_token=AKQMTLSRWFNF5ITXOCPS7ULRCDUPDA5CNFSM4KSDSDR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELHKPJY#issuecomment-583968679>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKQMTLQQGMSQ36QUUOR4KQDRCDUPDANCNFSM4KSDSDRQ> .

[iamareebjamal]

transitionTo throws an error in fastboot mode. Not because of a bug, it is by design. It is not meant to work in fastboot mode. Only on client

Read This:
ember-fastboot/fastboot#54

FastBoot should never call transitionTo
transitionTo should only be called client-side.

We use fastboot to render the HTML on server before it reaches client. This route only sends a POST request to API server and redirects. There is no HTML to be rendered, so why should it be handled on fastboot server?

[iamareebjamal]

Even if you replace transitionTo with replaceWith, you'll not get the route HTML - embermap/ember-cli-fastboot-testing#204

This is the disadvantage of letting a framework do the heavy lifting for us. We just don't have enough control

[iamareebjamal]

Moar examples - iezer/splanky@be70603

[iamareebjamal]

Issue opened since 2016 (about 4 years) - ember-fastboot/ember-cli-fastboot#202

[iamareebjamal]

More issues - ember-learn/ember-api-docs#128

You can try the "fix" using redirect instead of afterModel or model, but everything is a workaround when the issue is upstream - ember-learn/ember-api-docs#129

ember-learn/ember-api-docs#129
ember-learn/ember-api-docs#262

[kushthedude]

Didn't know the points you mentioned about the fastboot and transitions. It is pretty clear now the reason for the failures.👍

…

On Mon, 10 Feb, 2020, 12:56 Areeb Jamal, ***@***.***> wrote: More issues - ember-learn/ember-api-docs#128 <ember-learn/ember-api-docs#128> You can try the "fix" using redirect instead of afterModel or model, but everything is a workaround when the issue is upstream - https://github.com/ember-learn/ember-api-docs/pull/129/files — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#4038?email_source=notifications&email_token=AKQMTLW5AVCFSNQYKWNWUMLRCD6RNA5CNFSM4KSDSDR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELHPQRI#issuecomment-583989317>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKQMTLSB554X6UEXL2Z25LDRCD6RNANCNFSM4KSDSDRQ> .