Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: aligned address bottom bar #2385

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

Raunaksingh100
Copy link
Member

@Raunaksingh100 Raunaksingh100 commented Nov 8, 2020

Fixed-

#2135

description-

Fixed address bottom bar area not aligned in one line and not aligned with middle bar see in the screenshot for the better understanding.

screenshot before-

before

screenshot after--
after

Checklist

@@ -1525,7 +1525,7 @@ a {
}

.contact-details {
left: 40px;
left: 0px;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0px should be written without units as 0

@auto-label auto-label bot added the fix label Nov 8, 2020
@Raunaksingh100
Copy link
Member Author

@mariobehling @iamareebjamal can you review this pr

@mariobehling
Copy link
Member

Please stop pinging us on all channels constantly. Usually our priority is to focus on high priority issues first. If you want reviews you can also ask friends or other collaborators to help and review your code.

The issue here is not solved as required. The address should stay on the right side bar. There is no mention to move things to the central column.

You can compare this also to fossasia.org, which is similar in the design of the bottom bar. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants