-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing unsed Css for increasing performance ( with little formatting ) #1447
Conversation
Codecov Report
@@ Coverage Diff @@
## development #1447 +/- ##
===============================================
- Coverage 62.2% 62.06% -0.14%
===============================================
Files 51 51
Lines 1450 1450
Branches 181 181
===============================================
- Hits 902 900 -2
- Misses 438 439 +1
- Partials 110 111 +1
Continue to review full report at Codecov.
|
@mariobehling @praveenojha33 please review |
@rajvaibhavdubey @shreyanshdwivedi please review this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@subhahu123 I do not know how it is working fine for you but I am getting a lot of glitches while running Susper. Currently I am unable to get results therefore I am unable to review it properly. @AakashMallik @shreyanshdwivedi Please review.
Here you can see that top right service box collides with right screen.
Also please see your changes in other browsers.
@praveenojha33 can u please tell some more glitches |
@subhahu123 at first go I only found the service box alignment an issue, I'll try to find out glitches, if any and let you know |
@praveenojha33 please review |
@simsausaurabh please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- How did you ensure that nothing breaks or changes due to your changes?
- When you make a search query, while the results are being fetched and spinner is shown, result page should not be scrollable.
@praveenojha33 Can you please confirm that while we make a search query, and go back to main page, some of the links at footer are highlighted?
@simsausaurabh |
i think yes |
@shreyanshdwivedi Lets keep this as a low priority for now. It might break something. |
Fixes #1448
Checklist
master
branch.Changes proposed in this pull request: