Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(obligations_export): Add functionality to export obligations #53

Merged
merged 1 commit into from
May 20, 2024
Merged

feat(obligations_export): Add functionality to export obligations #53

merged 1 commit into from
May 20, 2024

Conversation

deo002
Copy link
Collaborator

@deo002 deo002 commented May 3, 2024

image

@deo002 deo002 requested a review from GMishx May 3, 2024 10:58
GMishx
GMishx approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good. Needs test.

GMishx
GMishx approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, working as expected.

@GMishx GMishx removed the needs test label May 14, 2024
@GMishx
Copy link
Member

GMishx commented May 14, 2024

@deo002 , can please change the resulted file name to replace : and + in the time with _? These special symbols can cause problems with different FS.

image

@GMishx GMishx mentioned this pull request May 14, 2024
Merged
@deo002 deo002 requested a review from GMishx May 15, 2024 09:56
GMishx
GMishx approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GMishx GMishx merged commit 64cbdc0 into fossology:main May 20, 2024
5 checks passed
@GMishx GMishx deleted the obligations_export branch May 20, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMishx GMishx GMishx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deo002 @GMishx