Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get CommandBox latest stable version on CI runtime #2

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

michaelborn
Copy link

This PR uses CommandBox's published versioning json file to retrieve the latest stable version number. Once that is done, the CI passes the obtained version through the docker build command and builds a new minibox image.

Once this PR is merged, bumping the commandbox version in Minibox is as easy as firing off a new build.

I recommend squashing when merging, it's not a big change. (Mostly in the GHA workflow)

@michaelborn michaelborn closed this Mar 9, 2023
@pfreitag
Copy link
Member

pfreitag commented Mar 9, 2023

Looks like a good idea @michaelborn

@michaelborn michaelborn reopened this Mar 10, 2023
@michaelborn
Copy link
Author

Whups - looks like I closed this PR by mistake? Ok, I opened it back up.

@pfreitag
Copy link
Member

@michaelborn thanks - there is another line that needs the $BOX_VERSION variable, line 51/52

@michaelborn
Copy link
Author

Thanks @pfreitag , done.

I'm not sure how to automate the README version table, though... that may be best left to human editors. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants