Add default settlement data to "add-settlement" handler in kingdom sheet

[MaximMukhanov]

Prevents kingdom sheet crash on adding settlement due to the lack of settlement data in "add-settlement" handler.

foundryvtt/foundryvtt-premium-content#898 - issue in foundry premium modules repo that explains the problem.

[CarlosFdez]

I'll dig into this soon and see if we can't solve this by using default values, but if I can't get something clean I'll simply merge this in. Thank you for looking into it.

[MaximMukhanov]

No problem, thank you for working on system!

[CarlosFdez]

From my initial investigation, this looks to be a bug with initial values of schema fields used in RecordField. Putting the schema field top level initializes all default values correctly, but it breaks apart entirely in the RecordField.

EDIT: this may be wrong, it may be data prep related

[MaximMukhanov]

From my initial investigation, this looks to be a bug with initial values of schema fields used in RecordField. Putting the schema field top level initializes all default values correctly, but it breaks apart entirely in the RecordField.

EDIT: this may be wrong, it may be data prep related

Also dug a bit on my lunch break today:D

It seems that "prepareBaseData" method incorrectly handles lack of settlement data provided by the handler.

for (const settlement of settlements) {
            if (!settlement) continue; // this line seems to be the culprit
            const typeData = KINGDOM_SETTLEMENT_TYPE_DATA[settlement.type];
            settlement.consumption.base = typeData.consumption;
            settlement.consumption.total = Math.max(0, typeData.consumption - settlement.consumption.reduction);
        }

Correct me if I'm wrong

[CarlosFdez]

stwlam did a fix last night, is this still an issue? Its because the actual data prep does a few extra things to lead to default values (clean and reset).

This was pre fix:

[CarlosFdez]

I tested and the bug seems to be resolved now. Thanks a lot for attempting to fix this, and for bringing this bug to our attention.

[MaximMukhanov]

I tested and the bug seems to be resolved now. Thanks a lot for attempting to fix this, and for bringing this bug to our attention.

Thank you for your work:D