-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows Jumplist plugin #669
Conversation
Zawadidone
commented
Apr 5, 2024
) | ||
|
||
@export(record=JumpListRecord) | ||
def jumplist(self) -> Iterator[JumpListRecord]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think additionally exporting the custom_destination
and automatic_destination
plugins would be nice. So you can choose between them. Something like:
target-query -f jumplist.automatic_destination
for just automatic_destination jumplists,target-query -f jumplist.custom_destination
for just custom_destination jumplists,target-query -f jumplist
for both.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it a known issue that namespace plugins do not work?
AttributeError: 'JumpListPlugin' object has no attribute 'SUBPLUGINS'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue persists.
`NamespacePlugin` results in the following error: AttributeError: 'JumpListPlugin' object has no attribute 'SUBPLUGINS'
…issect.target into feature/add_jumplist_plugin
@Zawadidone I also committed some suggestions directly in your PR, please check if you see anything wrong :). |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #669 +/- ##
==========================================
+ Coverage 75.39% 75.40% +0.01%
==========================================
Files 300 302 +2
Lines 26023 26152 +129
==========================================
+ Hits 19620 19720 +100
- Misses 6403 6432 +29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…issect.target into feature/add_jumplist_plugin
|
6464029 (#669) is fine! That actually was the first approach I took :) |
import io | ||
import logging | ||
from struct import error as StructError | ||
from typing import BinaryIO, Callable, Iterator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import io | |
import logging | |
from struct import error as StructError | |
from typing import BinaryIO, Callable, Iterator | |
from __future__ import annotations | |
import io | |
import logging | |
from struct import error as StructError | |
from typing import BinaryIO, Iterator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
""" | ||
yield from self._generate_records(self.automatic_destinations, AutomaticDestinationFile) | ||
|
||
def _generate_records(self, destinations: list, destination_file: Callable) -> Iterator[JumpListRecord]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
def _generate_records(self, destinations: list, destination_file: Callable) -> Iterator[JumpListRecord]: | |
def _generate_records( | |
self, destinations: list, destination_file: AutomaticDestinationFile | CustomDestinationFile | |
) -> Iterator[JumpListRecord] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
…issect.target into feature/add_jumplist_plugin