Add json output to target-query --list #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @JSCU-CNI , please open an issue and attache this PR so we can schedule a review into our sprints. |
Schamper
requested changes
Oct 7, 2024
Schamper
approved these changes
Oct 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #841 +/- ##
==========================================
+ Coverage 76.85% 76.87% +0.01%
==========================================
Files 318 318
Lines 27231 27258 +27
==========================================
+ Hits 20929 20955 +26
- Misses 6302 6303 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Horofic
pushed a commit
to JSCU-CNI/dissect.target
that referenced
this pull request
Oct 29, 2024
|
This PR does not seem to be merged, but I can see a merge commit in |
|
🤷 it's been merged twice now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds JSON output support to
target-query --listusing the--jsonflag. Fixes #887.