Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(uv) use dependency-groups.dev in pyproject.toml #23

Closed
wants to merge 2 commits into from

Conversation

zed
Copy link
Contributor

@zed zed commented Nov 1, 2024

@fpgmaas
Copy link
Owner

fpgmaas commented Nov 1, 2024

Thanks for the contribution!

0.4.6 doesn't support dependency-groups.dev
@zed zed marked this pull request as ready for review November 6, 2024 14:34
@fpgmaas
Copy link
Owner

fpgmaas commented Nov 13, 2024

@zed I see the build is failing, I think we also need to add default-groups = ["dev"]? https://docs.astral.sh/uv/concepts/dependencies/#default-groups

@fpgmaas
Copy link
Owner

fpgmaas commented Nov 27, 2024

@zed would you have time to take a look? Would be a nice improvement to merge this.

@zed
Copy link
Contributor Author

zed commented Nov 27, 2024

As far as I know, dev is on by default unless overridden. [I would have sworn I left this comment a while ago already]

@fpgmaas
Copy link
Owner

fpgmaas commented Dec 17, 2024

Closed in favour of #31, added you as co-author.

@fpgmaas fpgmaas closed this Dec 17, 2024
@zed zed deleted the patch-1 branch December 18, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use dependency-groups.dev instead of legacy tool.uv.dev-dependencies
2 participants