Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix license file creation #30

Merged
merged 11 commits into from
Dec 19, 2024
Merged

Conversation

MaKaNu
Copy link
Contributor

@MaKaNu MaKaNu commented Dec 4, 2024

PR Checklist

  • A description of the changes is added to the description of this PR.
  • If there is a related issue, make sure it is linked to this PR.
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Description of changes

I total agree with your suggestion from #29 and as promised here is my PR.

I have added the following new license files:

  • LICENSE_MIT
  • LICENSE_BSD
  • LICENSE_ISC
  • LICENSE_APACHE
  • LICENSE_GPL

The content was either from the official raw txt files (GPL and APACHE) or from Github.
The previous LICENSE file is now deleted.

Further, I have update post generation script to handle the different licenses and added tests for the various commands.

The changes do not affect the user directly, because now only the correct licenses are provided.

Just to inform:
Apache and GPLv3 are provided as are, since both don't include a copyright from the developer. They both only include information how to handle the licenses in the projects correctly. Changing those Licenses is not permitted, so they don't author and copyright of the users are not included.

@fpgmaas
Copy link
Owner

fpgmaas commented Dec 17, 2024

Sorry for the late reply! This looks great. Are you able to pull main and run the pre-commit hooks?

@MaKaNu
Copy link
Contributor Author

MaKaNu commented Dec 18, 2024

done. Having pre-commit only helps if I had installed the hooks. XD

@fpgmaas
Copy link
Owner

fpgmaas commented Dec 18, 2024

@MaKaNu Hey, sorry; looks like there is still a merge confict with uv.lock. Could you try to fetch latest changed from upstream? You can then just do rm uv.lock && uv lock to fix the conflict.

@MaKaNu
Copy link
Contributor Author

MaKaNu commented Dec 18, 2024

In the meantime, two other versions were already updated again. But now it seems fine

@fpgmaas fpgmaas merged commit 1e083e8 into fpgmaas:main Dec 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants