Add auth to metrics routes (#2115)

* feat: add metrics auth * feat: add auth to queue monitoring page
frain-dev · Aug 6, 2024 · 4f1b9e5 · 4f1b9e5
1 parent 76061ea
commit 4f1b9e5
Showing 1 changed file with 15 additions and 3 deletions.
diff --git a/api/api.go b/api/api.go
@@ -461,8 +461,16 @@ func (a *ApplicationHandler) BuildControlPlaneRoutes() *chi.Mux {
 
 	})
 
-	router.Handle("/queue/monitoring/*", a.A.Queue.(*redisqueue.RedisQueue).Monitor())
-	router.Handle("/metrics", promhttp.HandlerFor(metrics.Reg(), promhttp.HandlerOpts{}))
+	router.Route("/metrics", func(metricsRouter chi.Router) {
+		metricsRouter.Use(middleware.RequireAuth())
+		metricsRouter.Get("/", promhttp.HandlerFor(metrics.Reg(), promhttp.HandlerOpts{Registry: metrics.Reg()}).ServeHTTP)
+	})
+
+	router.Route("/queue", func(metricsRouter chi.Router) {
+		metricsRouter.Use(middleware.RequireAuth())
+		metricsRouter.Handle("/monitoring/*", a.A.Queue.(*redisqueue.RedisQueue).Monitor())
+	})
+
 	router.HandleFunc("/*", reactRootHandler)
 
 	metrics.RegisterQueueMetrics(a.A.Queue, a.A.DB)
@@ -474,7 +482,11 @@ func (a *ApplicationHandler) BuildControlPlaneRoutes() *chi.Mux {
 
 func (a *ApplicationHandler) BuildDataPlaneRoutes() *chi.Mux {
 	router := a.buildRouter()
-	router.Handle("/metrics", promhttp.HandlerFor(metrics.Reg(), promhttp.HandlerOpts{Registry: metrics.Reg()}))
+
+	router.Route("/metrics", func(metricsRouter chi.Router) {
+		metricsRouter.Use(middleware.RequireAuth())
+		metricsRouter.Get("/", promhttp.HandlerFor(metrics.Reg(), promhttp.HandlerOpts{Registry: metrics.Reg()}).ServeHTTP)
+	})
 
 	// Ingestion API.
 	router.Route("/ingest", func(ingestRouter chi.Router) {