Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add In-Memory Queue Support #342

Merged
merged 44 commits into from
Jan 22, 2022
Merged

Add In-Memory Queue Support #342

merged 44 commits into from
Jan 22, 2022

Conversation

ogbanugot
Copy link
Contributor

This pr adds support for in-memory queue configuration.

@ogbanugot ogbanugot requested review from subomi and jirevwe January 12, 2022 13:37
@netlify
Copy link

netlify bot commented Jan 12, 2022 •
edited
Loading

✔️ Deploy Preview for getconvoy canceled.

🔨 Explore the source changes: 2e251f4

🔍 Inspect the deploy log: https://app.netlify.com/sites/getconvoy/deploys/61ebcbc808bec100078ea246

@ogbanugot ogbanugot linked an issue Jan 12, 2022 that may be closed by this pull request
In-Memory Queue. #331
Closed
danvixent
danvixent reviewed Jan 12, 2022
View reviewed changes
worker/producer.go Outdated Show resolved Hide resolved
subomi
subomi requested changes Jan 15, 2022
View reviewed changes
Copy link
Collaborator

@subomi subomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @ogbanugot

queue/queue.go Outdated Show resolved Hide resolved
queue/queue.go Outdated Show resolved Hide resolved
queue/queue.go Outdated Show resolved Hide resolved
queue/storage.go Show resolved Hide resolved
worker/producer.go Outdated Show resolved Hide resolved
oneEyedSunday
oneEyedSunday reviewed Jan 15, 2022
View reviewed changes
cmd/main.go Outdated Show resolved Hide resolved
@ogbanugot ogbanugot requested a review from subomi January 16, 2022 14:42
subomi
subomi requested changes Jan 18, 2022
View reviewed changes
Copy link
Collaborator

@subomi subomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. To fix the broken CI we should

  • Add a Redis instance to .github/workflows/go.yml
  • Add a new step: Run Redis Integration tests
  • Specify integration tags on the Redis queue test file.

queue/redis/client_test.go Outdated Show resolved Hide resolved
queue/memqueue/client_test.go Outdated Show resolved Hide resolved
queue/memqueue/client_test.go Outdated Show resolved Hide resolved
queue/redis/client_test.go Outdated Show resolved Hide resolved
queue/memqueue/client_test.go Outdated Show resolved Hide resolved
@ogbanugot
Copy link
Contributor Author

Nice. To fix the broken CI we should

  • Add a Redis instance to .github/workflows/go.yml
  • Add a new step: Run Redis Integration tests
  • Specify integration tags on the Redis queue test file.

I noticed it was running everything twice, so I merged the two steps as one integration step

danvixent
danvixent reviewed Jan 18, 2022
View reviewed changes
queue/queue.go Show resolved Hide resolved
queue/redis/client_test.go Outdated Show resolved Hide resolved
@ogbanugot ogbanugot merged commit 186a2b7 into main Jan 22, 2022
@ogbanugot ogbanugot deleted the ogban/feature/in-memory-queue branch January 22, 2022 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danvixent danvixent danvixent left review comments

@oneEyedSunday oneEyedSunday oneEyedSunday left review comments

@jirevwe jirevwe jirevwe approved these changes

@subomi subomi subomi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In-Memory Queue.
5 participants
@ogbanugot @subomi @jirevwe @oneEyedSunday @danvixent