Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/ Extract TipTab Editor to Standalone Package and Integrate React App for Testing #694

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Feat/ Extract TipTab Editor to Standalone Package and Integrate React App for Testing #694

wants to merge 4 commits into from

Conversation

bddjong
Copy link
Contributor

@bddjong bddjong commented Apr 30, 2024 •
edited by AliKdhim87
Loading

Separates the TipTap editor from the strapi-tiptap-editor extension and adds a vercel dev sandbox

Todo

  • Fix translation injection
  • Fix Strapi user context (used for locale)
  • Support price extension with mock data
  • Integrate Jest
  • Deploy the Tiptap sandbox to Vercel.
  • Use Utrecht design-system components
    • Already replaced some of them
  • Use one type of icon from Tabler Icons react-icons/tb package
    • Already replaced some of them
  • Enable Image extension to work outside Strapi
  • Write more unit tests for each component & function
  • Fix the positioning issue: When starting a new line, returning to the previous line to update it causes a jump to the last text line.

@bddjong bddjong linked an issue Apr 30, 2024 that may be closed by this pull request
Testplan voor strapi & rte #580
Open
2 tasks
@AliKdhim87 AliKdhim87 force-pushed the feat/tip-tap-test-app branch from cb61f77 to 49a82b4 Compare July 1, 2024 12:27
@AliKdhim87 AliKdhim87 changed the title Feat/tip tap test app Feat/ Extract TipTab Editor to Standalone Package and Integrate React App for Testing Jul 2, 2024
@AliKdhim87 AliKdhim87 force-pushed the feat/tip-tap-test-app branch 5 times, most recently from 338b57c to c5884b7 Compare July 11, 2024 14:05
@AliKdhim87 AliKdhim87 force-pushed the feat/tip-tap-test-app branch 3 times, most recently from 460789f to b6903a0 Compare July 16, 2024 08:02
@AliKdhim87 AliKdhim87 marked this pull request as ready for review July 16, 2024 08:02
@AliKdhim87 AliKdhim87 force-pushed the feat/tip-tap-test-app branch 2 times, most recently from dc71dbf to d906767 Compare July 16, 2024 14:28
@vercel Vercel
Copy link

vercel bot commented Jul 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cms-frameless-io ❌ Failed (Inspect) Aug 27, 2024 11:33am
tiptap ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 27, 2024 11:33am

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 17, 2024 •
edited
Loading

Deploy preview for tiptap ready!

✅ Preview
https://tiptap-an1hx57lh-frameless.vercel.app

Built with commit a6301d7.
This pull request is being automatically deployed with vercel-action

@AliKdhim87 AliKdhim87 force-pushed the feat/tip-tap-test-app branch from d906767 to 367d87c Compare July 17, 2024 09:51
@AliKdhim87 AliKdhim87 force-pushed the feat/tip-tap-test-app branch from 367d87c to 7263ba2 Compare July 17, 2024 10:05
@AliKdhim87 AliKdhim87 force-pushed the feat/tip-tap-test-app branch from 7263ba2 to 2164462 Compare July 17, 2024 11:27
@AliKdhim87 AliKdhim87 force-pushed the feat/tip-tap-test-app branch from 2164462 to 582677f Compare July 18, 2024 09:24
@AliKdhim87 AliKdhim87 force-pushed the feat/tip-tap-test-app branch from 7943921 to 9b59dcc Compare July 19, 2024 10:14
@AliKdhim87 AliKdhim87 force-pushed the feat/tip-tap-test-app branch 2 times, most recently from cf1b014 to 5485325 Compare August 8, 2024 07:29
@codecov Codecov
Copy link

codecov bot commented Aug 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

@AliKdhim87 AliKdhim87 force-pushed the feat/tip-tap-test-app branch 2 times, most recently from 70d41c9 to a6301d7 Compare August 8, 2024 14:39
@AliKdhim87 AliKdhim87 force-pushed the feat/tip-tap-test-app branch from a6301d7 to 9ec7be9 Compare August 26, 2024 13:39
@AliKdhim87 AliKdhim87 force-pushed the feat/tip-tap-test-app branch from 9ec7be9 to bef9da3 Compare August 27, 2024 11:21
@AliKdhim87 AliKdhim87 force-pushed the feat/tip-tap-test-app branch from bef9da3 to 9f4e522 Compare August 27, 2024 11:30
@AliKdhim87 AliKdhim87 self-assigned this Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Robbert Robbert Robbert left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@AliKdhim87 AliKdhim87

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Testplan voor strapi & rte
3 participants
@bddjong @Robbert @AliKdhim87