Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's merge it! #210

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Let's merge it! #210

wants to merge 6 commits into from

Conversation

bgteach
Copy link

@bgteach bgteach commented Apr 23, 2024

截屏2024-04-23 11 58 16

bgteach added 5 commits April 20, 2024 20:10
A lot of optimisation for the ui (removing a lot of box nesting) and it now looks much more modern and coordinated with blender.
@franMarz
Copy link
Owner

It's great.
I just have to ask for the blenfile of that robot to be added to the resources, because if a new baking mode is added, someone will need to render a new thumbnail for the mode. Anyway, if you are open to do that on demand when necessary, we're good to go. Or we can add it as a theme, being the new main while keeping the old one behind an addon preferences option, and we can recover the old theme as the main one if this theme is not updated when needed. But this last option would require additional work now or after the merge of this pull, and I don't have too much time lately to do it, probably you've noticed that.
Thank you for sharing this!

@franMarz
Copy link
Owner

franMarz commented May 17, 2024

Btw, I think people wouldn't want the order of the baking modes thumbnails to change from alphabetic. And I see all the init file changed, it shouldn't be like that; you have to change the "End of Line Sequence" from LF to CRLF in your code editor and update this pull.

@bgteach
Copy link
Author

bgteach commented May 19, 2024

It's great. I just have to ask for the blenfile of that robot to be added to the resources, because if a new baking mode is added, someone will need to render a new thumbnail for the mode. Anyway, if you are open to do that on demand when necessary, we're good to go. Or we can add it as a theme, being the new main while keeping the old one behind an addon preferences option, and we can recover the old theme as the main one if this theme is not updated when needed. But this last option would require additional work now or after the merge of this pull, and I don't have too much time lately to do it, probably you've noticed that. Thank you for sharing this!

I'll adapt new thumbnails to the new version of the roast

@bgteach
Copy link
Author

bgteach commented May 19, 2024

Btw, I think people wouldn't want the order of the baking modes thumbnails to change from alphabetic. And I see all the init file changed, it shouldn't be like that; you have to change the "End of Line Sequence" from LF to CRLF in your code editor and update this pull.

Modified Complete:LF to CRLF

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready
Development

Successfully merging this pull request may close these issues.

2 participants