-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc fix + loadGmaps return promise #5
base: master
Are you sure you want to change the base?
doc fix + loadGmaps return promise #5
Conversation
Hello! I saw sources and got results from your module The `gmaps` property has PlaceResult object not GeocoderResult Here is the patch for this
I only forgot to change package.json for new version |
I try to test in my dev project but i cannot run even your original module I am doing:
npm run build
npm link
cd ~/my-project
npm link vue-geo-suggest
# nuxt
npm run dev
Can you help to me? :) P.S. I even did all recommended commads from your |
I was able to install your module from the repository and run without errors in this way:
Soon i will test my changes |
I can't get my patches to work. So far the problem is that I added async / await. Because of this, |
I did final changes and i tested in my project promise of |
It's cumulative commit of my two previous pull requests: #4 + #1 + new the feature:
Now the
loadGmaps
return promise fulfilled withtrue
as loaded successfully andfalse
as not loaded. I added examples for this in README.I didn't test it but i will soon. Please review this and if you will think that everything is ok please merge it ;-)