Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc fix + loadGmaps return promise #5

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Perlover
Copy link

It's cumulative commit of my two previous pull requests: #4 + #1 + new the feature:

Now the loadGmaps return promise fulfilled with true as loaded successfully and false as not loaded. I added examples for this in README.

I didn't test it but i will soon. Please review this and if you will think that everything is ok please merge it ;-)

@Perlover
Copy link
Author

I only forgot to change package.json for new version
If you will accept changes please change there the version number ;-)

@Perlover
Copy link
Author

Perlover commented Apr 24, 2020

I try to test in my dev project but i cannot run even your original module

I am doing:

  1. Cloned your project without my patches

  2. inside module dir i did:

npm run build
npm link
cd ~/my-project
npm link vue-geo-suggest
# nuxt
npm run dev
  1. I got errors in console when my component does import { GeoSuggest, loadGmaps } from 'vue-geo-suggest'
 ERROR  Failed to compile with 1 errors                                                                                                                                                                                                                                                             friendly-errors 15:18:22


 ERROR  in /home/user/tmp/orig-get-suggest/vue-geo-suggest/dist/vue-geo-suggest.esm.js                                                                                                                                                                                                          friendly-errors 15:18:22

Module build failed (from ./node_modules/eslint-loader/index.js):                                                                                                                                                                                                                                   friendly-errors 15:18:22
Error: Failed to load plugin 'prettier' declared in '../../tmp/orig-get-suggest/vue-geo-suggest/.eslintrc.js » @vue/eslint-config-prettier': Cannot find module 'eslint-plugin-prettier'
Require stack:
- /home/user/src/my-project/__placeholder__.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:980:15)
    at Function.Module._resolveFilename (/home/user/src/my-project/node_modules/module-alias/index.js:49:29)
    at Function.resolve (internal/modules/cjs/helpers.js:83:19)
    at Object.resolve (/home/user/src/my-project/node_modules/eslint/lib/shared/relative-module-resolver.js:44:50)
    at ConfigArrayFactory._loadPlugin (/home/user/src/my-project/node_modules/eslint/lib/cli-engine/config-array-factory.js:841:39)
    at /home/user/src/my-project/node_modules/eslint/lib/cli-engine/config-array-factory.js:730:33
    at Array.reduce (<anonymous>)
    at ConfigArrayFactory._loadPlugins (/home/user/src/my-project/node_modules/eslint/lib/cli-engine/config-array-factory.js:726:22)
    at ConfigArrayFactory._normalizeObjectConfigDataBody (/home/user/src/my-project/node_modules/eslint/lib/cli-engine/config-array-factory.js:552:32)
    at _normalizeObjectConfigDataBody.next (<anonymous>)
    at ConfigArrayFactory._normalizeObjectConfigData (/home/user/src/my-project/node_modules/eslint/lib/cli-engine/config-array-factory.js:491:20)
    at _normalizeObjectConfigData.next (<anonymous>)
    at ConfigArrayFactory._normalizeObjectConfigDataBody (/home/user/src/my-project/node_modules/eslint/lib/cli-engine/config-array-factory.js:545:25)
    at _normalizeObjectConfigDataBody.next (<anonymous>)
    at ConfigArrayFactory._normalizeObjectConfigData (/home/user/src/my-project/node_modules/eslint/lib/cli-engine/config-array-factory.js:491:20)
    at _normalizeObjectConfigData.next (<anonymous>)

Can you help to me? :)

P.S. I even did all recommended commads from your Project setup for contributing section from README - same error.

@Perlover
Copy link
Author

I was able to install your module from the repository and run without errors in this way:

  1. clone
  2. inside from repo dir: npm pack
  3. from my project: npm i ~/module-repo/vue-geo-suggest-1.0.2.tgz

Soon i will test my changes

@Perlover
Copy link
Author

I can't get my patches to work. So far the problem is that I added async / await. Because of this, dist/* files were not built. After I added rollup-plugin-nodent plugin for rollup and successfully built and installed the module. But a message appears in the browser after this: TypeError: "(intermediate value).$asyncbind is not a function"

@Perlover
Copy link
Author

I did final changes and i tested in my project promise of loadGmaps - there everything works
But i see some understable by me Travis errors after last commit...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant