Merge branch 'master' into master

frankodoom · Nov 11, 2024 · ba179e4 · ba179e4
2 parents cd3c764 + 99cb9a1
commit ba179e4
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 14 deletions.
diff --git a/README.md b/README.md
@@ -131,7 +131,6 @@ We are committed to fostering a welcoming and respectful community for everyone.
 
 
 ### Comming Soon
-* Support for ISO 4217 Currency Codes
 * Support for ISO 3166 Country A3 Codes
 * Country ShortCode Enums 
 

diff --git a/src/CountryData.Standard/data.json b/src/CountryData.Standard/data.json
@@ -16498,39 +16498,39 @@
     ],
     "regions": [
       {
-        "name": "Basnahira",
+        "name": "Western Province",
         "shortCode": "1"
       },
       {
-        "name": "Dakunu",
+        "name": "Southern Province",
         "shortCode": "3"
       },
       {
-        "name": "Madhyama",
+        "name": "Central Province",
         "shortCode": "2"
       },
       {
-        "name": "Naegenahira",
+        "name": "Eastern Province",
         "shortCode": "5"
       },
       {
-        "name": "Sabaragamuwa",
+        "name": "Sabaragamuwa Province",
         "shortCode": "9"
       },
       {
-        "name": "Uturu",
+        "name": "Northern Province",
         "shortCode": "4"
       },
       {
-        "name": "Uturumaeda",
+        "name": "North Central Province",
         "shortCode": "7"
       },
       {
-        "name": "Vayamba",
+        "name": "North Western Province",
         "shortCode": "6"
       },
       {
-        "name": "Uva",
+        "name": "Uva Province",
         "shortCode": "8"
       }
     ]

diff --git a/test/CountryData.UnitTests/CountryHelperTests.cs b/test/CountryData.UnitTests/CountryHelperTests.cs
@@ -130,9 +130,7 @@ public void GetCountriesByPhoneCode_WithCorrectPhoneCode_ShouldReturnCountries(s
         countries.Any(c => c.CountryShortCode == expectedShortCode).Should().BeTrue();
     }
 
-
-
-    /// <summary>
+  /// <summary>
     /// Tests the GetCurrencyCodesByCountryCode method in the CountryHelper class.
     /// This test verifies if the method correctly returns the primary currency (code and name) for a given country's short code.
     /// Assumes that each country has one primary currency for simplicity.
@@ -210,7 +208,24 @@ public void GetCountryByCurrencyCode_WhenCountryDataIsNotInitialized_ShouldThrow
         act.Should().Throw<InvalidOperationException>().WithMessage("Country data is not initialized.");
     }
 
+    /// <summary>
+    ///  Tests the GetRegionByCountryCode method in the CountryHelper class.
+    ///  This test verifies if the method correctly returns the regions associated with a given country's short code.
+    /// </summary>
+    /// <param name="shortCode">The short code of the country for which the regions are to be retrieved.</param>
 
+    [Theory]
+    [InlineData("LK")]
+    public void GetRegions_WithCorrectCode_ShouldReturnCountryRegions(string shortCode)
+    {
+        //Act
+        var regions = _countryHelper.GetRegionByCountryCode(shortCode);
 
-
+        //Assert
+        regions.Should().NotBeNull();
+        if (shortCode == "LK")
+        {
+            regions.Should().HaveCount(9);
+        }
+    }
 }