Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kroxy system tests sb #52

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

SamBarker
Copy link

Type of change

Select the type of your PR

  • Bugfix
  • Enhancement / new feature
  • Refactoring
  • Documentation

Description

Please describe your pull request

Additional Context

Why are you making this pull request?

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • Write tests
  • Make sure all tests pass
  • Review performance test results. Ensure that any degradations to performance numbers are understood and justified.
  • Make sure all Sonar-Lint warnings are addressed or are justifiably ignored.
  • Update documentation
  • Reference relevant issue(s) and close them after merging
  • For user facing changes, update CHANGELOG.md (remember to include changes affecting the API of the test artefacts too).

@SamBarker
Copy link
Author

N.b I tested the PR by adding a dependency from kroxylicious-sample to the system tests and the build failed with

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:3.4.1:enforce (enforce-systemtest-isolation) on project kroxylicious-sample: 
[ERROR] Rule 0: org.apache.maven.enforcer.rules.dependency.BannedDependencies failed with message:
[ERROR] io.kroxylicious:kroxylicious-sample:jar:0.4.0-SNAPSHOT
[ERROR]    io.kroxylicious:kroxylicious-systemtests:jar:0.4.0-SNAPSHOT <--- banned via the exclude/include list
[ERROR] 

… system tests in other modules

Signed-off-by: Sam Barker <[email protected]>

rh-pre-commit.version: 2.0.1
rh-pre-commit.check-secrets: ENABLED
Copy link
Owner

@franvila franvila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! Much more cleaner in that way!

@franvila franvila merged commit 4ac3f46 into franvila:KroxySystemTests Nov 21, 2023
1 check passed
@SamBarker SamBarker deleted the KroxySystemTests-SB branch November 22, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants