Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load Studio packages before dump #78

Closed
wants to merge 1 commit into from
Closed

Load Studio packages before dump #78

wants to merge 1 commit into from

Conversation

Arcesilas
Copy link
Contributor

@Arcesilas Arcesilas commented Sep 11, 2017

By default, when running composer dump-autoload, Studio packages are not loaded. Because of it, their autoload directive, in their composer.json is not included in composer root autoload. To have them included, it's required to composer update which is much longer and not the appropriate way to just dump-autoload.

@franzliedke
Copy link
Owner

So, are you suggesting that with this change you could simply call composer dump-autoload straight after running studio load your/package?

I don't see how this should work, given that composer update (or install) needs to be executed at least once for the symlink to be generated.

@Arcesilas
Copy link
Contributor Author

Wow... been a while... :)

I think I remember I had a problem with autoload not correctly generated since packages loaded (symlinked) with studio were not added. when running composer dump-autoload. I don't remember how I got to this modification, where I found ScriptEvents::PRE_AUTOLOAD_DUMP, but I guess it solved the problem I had...

Anyway, I've recently experienced this same problem, while using the version with this modification... I'm sorry I cannot tell you more :/

@franzliedke
Copy link
Owner

Thanks for responding so quickly!

Okay then, I think this will be fixed in the course of fixing #52 by merging #73.

@franzliedke franzliedke closed this Dec 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants