Fix "Package seems not been installed properly" #87
Conversation
The installationSource and distType on original packages are reconfigured in the uninstall/install step. This prevents the "Package seems not been installed properly" error, and also "The package has modified files" warning after running `composer update`. Update StudioPlugin.php
|
I confirm this fixes the "Package seems not been installed properly" error. I noticed something odd in the output though: $ composer update foo/foo-bundle
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 1 install, 0 updates, 0 removals
- Installing foo/foo-bundle (dev-some-branch 455d8a2): Cloning 455d8a2cab from cache
Writing lock file
Generating autoload files
[Studio] Loading package foo/foo-bundle
ocramius/package-versions: Generating version class...
ocramius/package-versions: ...done generating version class
- Removing foo/foo-bundle (dev-some-branch 455d8a2)
- Installing foo/foo-bundle (0.4.x-dev): Symlinking from ../foo-bundleIn my |
src/Composer/StudioPlugin.php
Outdated
| $original = $installed->findPackage($package->getName(), '*'); | ||
|
|
||
| // Change the source type to path, to prevent 'The package has modified files' | ||
| $original->setInstallationSource('dist'); | ||
| $original->setDistType('path'); |
There was a problem hiding this comment.
This line raises an error when $original is an instance of AliasPackage:
PHP Fatal error: Uncaught Error: Call to undefined method Composer\Package\AliasPackage::setDistType()
There was a problem hiding this comment.
Thanks for highlighting this. I've just run into this issue myself today. I'm now testing out a fix with my latest commit.
This does highlight a valid concern about the many configurations possible with composer. My workflow is simple, with packages installed through Packagist or VCS by tag or by branch. I'm sure theres plenty of other possibilities that my proposed change would not work for. That said - I'm not exactly sure how many of those workflows were possible before my commit?
|
These changes seem to have a drawback: requiring a dev branch in |
src/Composer/StudioPlugin.php
Outdated
| $installationManager->getInstaller($package->getType()) | ||
| ->install($studioRepo, $package); | ||
| $installationManager->getInstaller($original->getType())->uninstall($installed, $original); | ||
| $installationManager->getInstaller($package->getType())->install($LocalPackagesRepo, $package); |
There was a problem hiding this comment.
@ryzr I am getting issues since this commit. $LocalPackagesRepo is not defined. I have PR'ed to your fork https://github.com/ryzr/studio/pull/1
Fix for undefined LocalPackagesRepo variable
The installationSource and distType on original packages are reconfigured in the uninstall/install step. This prevents the "Package seems not been installed properly" error, and also "The package has modified files" warning after running
composer update. I also made a change to the loading/detection of Studio packages in the pre/post autoload phases. This should ensure consistency and no clashes with other plugins.I'm not sure what the purpose of the
/compost/studio/installed.jsonfile is (except for debugging), but things should run fine without it. I've left it there for now, as it may be valuable info to some.I was able to
composer install,composer updateandcomposer dumpautowithout any errors. I made changes to the autoload config in my symlinked packages, and it was reflected in the composer/autoload_x files.It should be noted however, that I only tested with 'library' package types, downloaded from source (Bitbucket). I'm not sure what troubles might arise with dist packages or other composer package types.