Add dropdown menus to timepicker #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using sliders to change hours, minutes and seconds is cumbersome to many users. Especially entering "clean" times like 09:15:00 is a pain, as the sliders are pretty short. This pull request adds dropdown menus to the hours, minutes and seconds values. The "hours" dropdown menu has submenus for each hour with 00:00, 15:00, 30:00 and 45:00 settings for minutes and seconds. This makes it easy to select clean time slots. The dropdown menus for minutes and seconds menus have their values in 5 minutes/seconds steps, with a submenu to select the values in between. To minimize the required mouse interaction, the dropdowns and submenus open on mouse over (hover). The min/max values for hours, minutes and seconds are respected. Also includes a trivial fix for the spacing between the minutes and seconds slider.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using sliders to change hours, minutes and seconds is cumbersome to many users. Especially entering "clean" times like 09:15:00 is a pain, as the sliders are pretty short.
This pull request adds dropdown menus to the hours, minutes and seconds values. The "hours" dropdown menu has submenus for each hour with 00:00, 15:00, 30:00 and 45:00 settings for minutes and seconds. This makes it easy to select clean time slots. The dropdown menus for minutes and seconds menus have their values in 5 minutes/seconds steps, with a submenu to select the values in between.
To minimize the required mouse interaction, the dropdowns and submenus open on mouse over (hover). The min/max values for hours, minutes and seconds are respected.
PS: Also includes a trivial fix for the spacing between the minutes and seconds slider.
See it in action, using the
visual-tests.htmlfile: