Skip to content

Commit

Permalink
refactor: use env to trigger using-cached flag
Browse files Browse the repository at this point in the history
Click supports pulling args from an envvar if it is present,
this would be quicker and cleaner than calling a dummy command
to check if the feature is supported
  • Loading branch information
18alantom committed Jan 18, 2024
1 parent d177d8f commit 683a421
Showing 1 changed file with 4 additions and 10 deletions.
14 changes: 4 additions & 10 deletions bench/utils/bench.py
Original file line number Diff line number Diff line change
Expand Up @@ -354,17 +354,11 @@ def build_assets(bench_path=".", app=None, using_cached=False):
if app:
command += f" --app {app}"

if using_cached and can_use_cached(bench_path):
command += " --using-cached"
env = {"BENCH_DEVELOPER": "1"}
if using_cached:
env["USING_CACHED"] = "1"

exec_cmd(command, cwd=bench_path, env={"BENCH_DEVELOPER": "1"})

def can_use_cached(bench_path=".") -> bool:
cmd = ["bench", "can-use-cached"]
return_code = subprocess.call(
cmd, cwd=bench_path, stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL,
)
return not return_code
exec_cmd(command, cwd=bench_path, env=env)

def handle_version_upgrade(version_upgrade, bench_path, force, reset, conf):
from bench.utils import log, pause_exec
Expand Down

0 comments on commit 683a421

Please sign in to comment.