Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for sticky columns #205

Merged
merged 6 commits into from
Feb 21, 2025
Merged

Conversation

iamejaaz
Copy link
Member

When sticky = true is passed to the columns, they will automatically stick to the left while scrolling.
image

Screenshot / GIF

Screen.Recording.2025-02-19.at.4.05.52.PM.mov

no-docs

@iamejaaz iamejaaz merged commit 82582a0 into frappe:master Feb 21, 2025
1 check passed
Copy link

🎉 This PR is included in version 1.18.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ankush
Copy link
Member

ankush commented Feb 21, 2025

@iamejaaz any way to do this from UI? We don't want to limit this to just script/code.

It will be small addition, somewhere in column dropdown add option to pin that column.

@iamejaaz
Copy link
Member Author

@iamejaaz any way to do this from UI?

No, right now

It will be small addition, somewhere in column dropdown add option to pin that column.

Yeah, I was thinking the same thing—adding an option in the dropdown to fix the column. The issue, however, is that it’s currently not maintaining the state for this. If the page is reloaded, it would need to redo everything (like sorting, pinning of columns). To address this, it would first need to store the state somewhere (like local storage) or any another solution/suggestion?

image

@ankush
Copy link
Member

ankush commented Feb 21, 2025

Keeping it stateless is fine to begin with IMO, but if you can do both then sure, why not.

@ankush
Copy link
Member

ankush commented Feb 21, 2025

The problem with stateful config is there are many dynamic data tables in Framework. Even reports inside code don't have known column names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants